[PATCH] smb: common: add header guards to fs/smb/common/smb2status.h

Stefan Metzmacher metze at samba.org
Fri Feb 6 09:42:11 UTC 2026


Am 05.02.26 um 22:31 schrieb David Howells:
> Stefan Metzmacher <metze at samba.org> wrote:
> 
>> diff --git a/fs/smb/client/Makefile b/fs/smb/client/Makefile
>> index 802dec276e15..3abd357d6df6 100644
>> --- a/fs/smb/client/Makefile
>> +++ b/fs/smb/client/Makefile
>> @@ -47,7 +47,7 @@ cifs-$(CONFIG_CIFS_COMPRESSION) += compress.o compress/lz77.o
>>   #
>>   # Build the SMB2 error mapping table from smb2status.h
>>   #
>> -$(obj)/smb2_mapping_table.c: $(srctree)/fs/smb/common/smb2status.h \
>> +$(obj)/smb2_mapping_table.c: $(src)/../common/smb2status.h \
>>                              $(src)/gen_smb2_mapping
>>          $(call cmd,gen_smb2_mapping)
> 
> That looks reasonable.  Do you have a patch for it, if so, you can add:
> 
> 	Reviewed-by: David Howells <dhowells at redhat.com>

I'd propose that Steve just squashes this into your commit
cifs: Autogenerate SMB2 error mapping table

Thanks!
metze




More information about the samba-technical mailing list