Fwd: [PATCH 0/3] ksmbd: More crypto library conversions

Steve French smfrench at gmail.com
Tue Oct 14 23:25:04 UTC 2025


Adding linux-cifs mailing lists for more visibility to these changes

---------- Forwarded message ---------
From: Eric Biggers <ebiggers at kernel.org>
Date: Tue, Oct 14, 2025 at 6:18 PM
Subject: [PATCH 0/3] ksmbd: More crypto library conversions
To: <linux-cifs at vger.kernel.org>, Namjae Jeon <linkinjeon at kernel.org>,
Steve French <smfrench at gmail.com>
Cc: Sergey Senozhatsky <senozhatsky at chromium.org>, Tom Talpey
<tom at talpey.com>, <linux-crypto at vger.kernel.org>,
<linux-kernel at vger.kernel.org>, Eric Biggers <ebiggers at kernel.org>


This series converts fs/smb/server/ to access SHA-512, HMAC-SHA256, and
HMAC-MD5 using the library APIs instead of crypto_shash.

This simplifies the code significantly.  It also slightly improves
performance, as it eliminates unnecessary overhead.  I haven't done
server-specific benchmarks, but you can get an idea of what to expect by
looking at the numbers I gave for the similar client-side series:
https://lore.kernel.org/linux-cifs/20251014034230.GC2763@sol/

No change in behavior intended.  All the crypto computations should be
the same as before.  I haven't tested this series (I did test the
similar client-side series), but everything should still work.

Eric Biggers (3):
  ksmbd: Use SHA-512 library for SMB3.1.1 preauth hash
  ksmbd: Use HMAC-SHA256 library for message signing and key generation
  ksmbd: Use HMAC-MD5 library for NTLMv2

 fs/smb/server/Kconfig      |   6 +-
 fs/smb/server/auth.c       | 390 +++++++------------------------------
 fs/smb/server/auth.h       |  10 +-
 fs/smb/server/crypto_ctx.c |  24 ---
 fs/smb/server/crypto_ctx.h |  15 +-
 fs/smb/server/server.c     |   4 -
 fs/smb/server/smb2pdu.c    |  26 +--
 fs/smb/server/smb_common.h |   2 +-
 8 files changed, 87 insertions(+), 390 deletions(-)


base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
--
2.51.0



-- 
Thanks,

Steve



More information about the samba-technical mailing list