[PATCH] smb: client: Move an error code assignment in smb3_init_transform_rq()

Steve French smfrench at gmail.com
Wed Oct 8 21:17:30 UTC 2025


It won't any difference to perf since compiler will optimize, but it could
be worth fixing if it shrinks code

Thanks,

Steve

On Wed, Oct 8, 2025, 4:00 PM Markus Elfring <Markus.Elfring at web.de> wrote:

> > Also when a patch doesn't shrink code, but even grows it by one line,
> and doesn't make it much clearer, it is probably not worth changing (it
> complicates future backports of real fixes in the future eg). Let's limit
> these to those that shrink code and make code clearer (or ideally fix
> potential bugs)
>
> Do you insist to keep an extra initialisation for the local variable “rc”
> despite of the implementation detail that the value “-ENOMEM” is needed
> only for a single if branch here?
>
> Regards,
> Markus
>


More information about the samba-technical mailing list