[PATCH v3 0/4] smb: smbdirect/client/server: relax WARN_ON_ONCE(SMBDIRECT_SOCKET_*) checks

Steve French smfrench at gmail.com
Fri Nov 28 04:53:54 UTC 2025


On Thu, Nov 27, 2025 at 9:19 PM Namjae Jeon <linkinjeon at kernel.org> wrote:

> On Fri, Nov 28, 2025 at 12:54 AM Stefan Metzmacher <metze at samba.org>
> wrote:
> >
> > Am 26.11.25 um 02:07 schrieb Namjae Jeon:
> > > On Wed, Nov 26, 2025 at 8:50 AM Namjae Jeon <linkinjeon at kernel.org>
> wrote:
> > >>
> > >> On Tue, Nov 25, 2025 at 11:22 PM Stefan Metzmacher <metze at samba.org>
> wrote:
> > >>>
> > >>> Hi,
> > >>>
> > >>> here are some small cleanups for a problem Nanjae reported,
> > >>> where two WARN_ON_ONCE(sc->status != ...) checks where triggered
> > >>> by a Windows 11 client.
> > >>>
> > >>> The patches should relax the checks if an error happened before,
> > >>> they are intended for 6.18 final, as far as I can see the
> > >>> problem was introduced during the 6.18 cycle only.
> > >>>
> > >>> Given that v1 of this patchset produced a very useful WARN_ONCE()
> > >>> message, I'd really propose to keep this for 6.18, also for the
> > >>> client where the actual problem may not exists, but if they
> > >>> exist, it will be useful to have the more useful messages
> > >>> in 6.16 final.
> > > Anyway, Applied this patch-set to #ksmbd-for-next-next.
> > > Please check the below issue.
> >
> > Steve, can you move this into ksmbd-for-next?
> Steve, There are more patches in ksmbd-for-next-next.
> Please apply the following 6 patches in #ksmbd-for-next-next to
> #ksmbd-for-next.
>
> 3858665313f1 (HEAD -> ksmbd-for-next-next, origin/ksmbd-for-next-next)
> ksmbd: ipc: fix use-after-free in ipc_msg_send_request
> b9c7d4fe6e93 smb: client: relax WARN_ON_ONCE(SMBDIRECT_SOCKET_*)
> checks in recv_done() and smbd_conn_upcall()
> 6c5ceb636d08 smb: server: relax WARN_ON_ONCE(SMBDIRECT_SOCKET_*)
> checks in recv_done() and smb_direct_cm_handler()
> d02a328304e5 smb: smbdirect: introduce
> SMBDIRECT_CHECK_STATUS_{WARN,DISCONNECT}()
> 340255e842d5 smb: smbdirect: introduce SMBDIRECT_DEBUG_ERR_PTR() helper
> 01cba263d1bd ksmbd: vfs: fix race on m_flags in vfs_cache
>
>
> Done


-- 
Thanks,

Steve


More information about the samba-technical mailing list