[PATCH 1/5] smb: common: split out smb_direct related header files
Steve French
smfrench at gmail.com
Tue May 27 19:14:51 UTC 2025
On Tue, May 27, 2025 at 1:50 PM Tom Talpey <tom at talpey.com> wrote:
>
> I love the idea. Couple of questions on the pathnames...
>
> On 5/27/2025 12:12 PM, Stefan Metzmacher wrote:
> > This is just a start moving into a common smb_direct layer.
> >
> > Cc: Steve French <smfrench at gmail.com>
> > Cc: Tom Talpey <tom at talpey.com>
> > Cc: Long Li <longli at microsoft.com>
> > Cc: Namjae Jeon <linkinjeon at kernel.org>
> > Cc: Hyunchul Lee <hyc.lee at gmail.com>
> > Cc: linux-cifs at vger.kernel.org
> > Cc: samba-technical at lists.samba.org
> > Signed-off-by: Stefan Metzmacher <metze at samba.org>
> > ---
> > fs/smb/common/smb_direct/smb_direct.h | 11 +++++
> > fs/smb/common/smb_direct/smb_direct_pdu.h | 51 +++++++++++++++++++++++
>
> Why the underscore in "smb_direct", in both components? The protocol
> doesn't use this, and it seems awkward and search-unfriendly.
I agree that it would be less confusing if smbdirect instead of
smb_direct in the file/directory names
More information about the samba-technical
mailing list