[PATCH v2 01/12] smb: smbdirect: add smbdirect_pdu.h with protocol definitions

[Namjae Jeon]

[snip]
> >>> He can just put these changes in his own queue and work on them.
> >>> I am pointing out why he is trying to put unfinished things in the public queue.
> >>
> >> Because I want to base the next steps on something that is already accepted.
> >>
> >> I really don't want to work on it for weeks and then some review will void
> >> that work completely and I can start again.
> > It was too tiny a step and unclear.
> > i.e. the patch description should not have comments like "It will be
> > used in the next commits..."
>
> What should it say if something is introduced but not yet used?
>
> I mean I could explain in more detail how it will be used in
> the next commits?
It should be added when it is used. If it is not used, it does not
need to be added now.
>
> >>> If You want to apply it, Please do it only on cifs.ko. When it is
> >>> properly implemented, I want to apply it to ksmbd.
> >>
> >> I can keep the ksmbd patches rebased on top and send them again
> >> each time to get more feedback.
> >>
> >> Would that work for you?
> > Okay, Please re-include the ksmbd patches in the next patch-set and I
> > will check them.
> >>
> >> The key for me is discuss patches first and have them reviewed early
> >> so that the following work rely on. Any the tiny steps should
> >> make it possible to do easy review and make it possible to test each
> >> tiny step.
> > Okay. I agreed. But It should not be too tiny.
> > As I said above, please don't send it in pieces that I can understand
> > by looking at the next commits.
>
> I'll try to keep them tiny they can always be squashed later,
> but splitting them again would be a pain.
I am sorry, there was a misunderstanding.
What I mean is not that each patch is too tiny, but that the entire
patch-set is small.
So It is not clearly concluded in the patch-set and I have to wait for
the next commits to understand it.
>
> You can apply them and do a diff over multiple patches
> and tell me which commits I should squash.
Okay. Let me check them on the next patch-set.
Thanks!
>
> Thanks!
> metze