[PATCH][cifs-utils] avoid using mktemp when updating mtab

Shyam Prasad N nspmangalore at gmail.com
Wed Jan 22 09:33:59 UTC 2025


On Tue, Jan 21, 2025 at 6:19 AM Steve French <smfrench at gmail.com> wrote:
>
> Attached patch to  Fix build warning: cifs-utils/mount.cifs.c:1726:
>     warning: the use of `mktemp' is dangerous, better use `mkstemp' or `mkdtemp'
>
> Use of mktemp() has been deprecated (e.g. due to security issues with
> symlink races), and instead mkstemp is often recommended.  Change
> the use of mktemp to mkstemp in del_mtab in cifs-utils
>
> Fixes: f46dd7661cfb ("mount.cifs: Properly update mtab during remount")
>
> Opinions? Better way to address it?
>
> --
> Thanks,
>
> Steve

Seems like a reasonable change. RB

-- 
Regards,
Shyam



More information about the samba-technical mailing list