Current Samba master incorrectly returns STATUS_INVALID_HANDLE on copy_chunk

Ralph Boehme slow at samba.org
Tue Oct 8 09:35:16 UTC 2024


On 10/8/24 10:45 AM, Ralph Boehme wrote:
> On 10/8/24 10:41 AM, Ralph Boehme via samba-technical wrote:
>> The problem is the O_APPEND on the destination file handle.
>>
>> We pass that flag if
>>
>>          if (posix_open && (access_mask & FILE_APPEND_DATA)) {
>>                  flags |= O_APPEND;
>>          }
>>
>> Is this on a posix mount? Otherwise it seems to be the clients fault 
>> passing FILE_APPEND_DATA.
> 
> gah, it's an "&&", not an "||", so it's your client I would say.

thinking about it, I wonder whether that condition is actually useful or 
if we should remove it.

@Jeremy (or others): mapping from FILE_APPEND_DATA access mask to open 
flag O_APPEND seems wrong imho. Do you remember why you added it? Or 
anyone else?

-slow
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20241008/29888200/OpenPGP_signature.sig>


More information about the samba-technical mailing list