Current Samba master incorrectly returns STATUS_INVALID_HANDLE on copy_chunk

[Ralph Boehme]

On 10/9/24 9:43 PM, Jeremy Allison wrote:
> Can we just map (access_mask (FILE_APPEND_DATA|SYNCHRONIZE)) ==  
> (FILE_APPEND_DATA|SYNCHRONIZE))
> to O_APPEND, regardless of POSIX mode ?

thinking about this a bit more, this seems doable, albeit only for POSIX 
mode. For non-POSIX mode we could potentially break WIndows application 
that open only with FILE_APPEND_DATA: I checked with a torture test that 
Windows doesn't enforce append behaviour for FILE_APPEND_DATA|SYNCHRONIZE.

For POSIX opens we should also allow combinations like 
FILE_READ_ATTRIBUTES|FILE_APPEND_DATA to map to O_APPEND, so clients can 
write in append mode to the handle and still are able to fstat() it.

https://gitlab.com/samba-team/samba/-/merge_requests/3863

Thoughts?

-slow
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20241109/7c2de322/OpenPGP_signature.sig>