Fwd: Regression: ldb performance with indexes

Andrew Bartlett abartlet at samba.org
Wed May 1 00:42:48 UTC 2024


On Wed, 2024-04-17 at 15:53 +0200, Andreas Schneider wrote:
> On Friday, 22 March 2024 21:35:27 GMT+2 Andrew Bartlett via samba-
> technical wrote:
> > Firstly, these are very impressive improvements.
> 
> Hi Andréas,
> I agree, this is great work. 
> > Thanks so much for your work debugging this and getting to the root
> > ofthe problem, this is very much appreciated.Do you have any data
> > on how much of the improvement is due to ldbpatch, and how much is
> > due to each of the other patches?
> > Did you happen to use Brendan Greg's FlameGraph tool for the
> > debugging(this is what we often use), and if so, can you share the
> > graphs?  Iwant to understand if perhaps we need to consider
> > restructuring thecaller.
> > https://www.brendangregg.com/FlameGraphs/cpuflamegraphs.html#Instructions
> > 
> > For this series if you could please: - send in a send in a Samba
> > Developer Declaration per
> > https://www.samba.org/samba/devel/copyright-policy.html
> >  - create a gitlab account - let me know the username
> > Once I give you access to the devel repo, so you can run the
> > fulltestsuite under our quota, please follow our contribution steps
> > here:
> > https://wiki.samba.org/index.php/Contribute#Subsequent_Merge_Requests_(and_c
> > omplex_first_requests)
> 
> I didn't see a merge request so far? Any update on that?

Andréas,
Thanks for creating a GitLab account and following up on our paperwork.
I can see your MR for the tdb_find patches, but it would be awesome if
you could raise one for the LDB in-memory-TDB change also. 

In the meantime Douglas is running a performance test on our test
server to confirm things, but it would be great to move this along so
our users can benefit.

Make sure to include your Signed-off-by and 

BUG: 
https://bugzilla.samba.org/show_bug.cgi?id=15590 id="-x-evo-selection-start-marker">
Thanks,
Andrew Bartlett


More information about the samba-technical mailing list