[External] : Re: missing krb5 dependencies after recent changes in nightly bits

[Vita Batrla]

Thank you! That might be it.
Let me try to build with your patch.

Vita

On Wed, Jun 05, 2024 at 05:50:17PM +0200, Stefan Metzmacher wrote:
> Am 05.06.24 um 17:40 schrieb Vita Batrla via samba-technical:
> > I found the changeset that introduced the regression.
> > The git bisect command says the culprit is:
> > 
> > $ git bisect bad
> >
> > I suspect this change in lib/addns/wscript_build:
> > 
> > @@ -11,6 +11,6 @@ bld.SAMBA_LIBRARY('addns',
> >                         error.c
> >                         dnsquery_srv.c
> >                     ''',
> >                     public_deps='samba-util gssapi ndr resolv dns_lookup',
> >                     public_deps='samba-util gensec ndr resolv dns_lookup',
> 
> Sorry for breaking it, I missed this:
> 
> From 67f686a9495649cc2c201c051aaa35d5d8c64133 Mon Sep 17 00:00:00 2001
> From: Stefan Metzmacher <metze at samba.org>
> Date: Wed, 5 Jun 2024 17:46:53 +0200
> Subject: [PATCH] lib/addns: remove unused kerberos/gssapi includes in dns.h
> 
> Signed-off-by: Stefan Metzmacher <metze at samba.org>
> ---
>  lib/addns/dns.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/lib/addns/dns.h b/lib/addns/dns.h
> index abf0906fdabe..6e605cbec2eb 100644
> --- a/lib/addns/dns.h
> +++ b/lib/addns/dns.h
> @@ -27,8 +27,6 @@
> 
>  #include "../replace/replace.h"
>  #include "system/network.h"
> -#include "system/kerberos.h"
> -#include "system/gssapi.h"
> 
>  /* make sure we have included the correct config.h */
>  #ifndef NO_CONFIG_H /* for some tests */
> -- 
> 2.34.1
>