missing krb5 dependencies after recent changes in nightly bits

[Vita Batrla]

Hello,

>From time to time I compile Samba source code from:
https://github.com/samba-team/samba.git

- it used to work few weeks ago
- it doesn't work as of today

Please find the error messages in attached file.  The build system is
Solaris and it uses MIT Kerberos libraries from the system. The krb5.h
isn't in a standard location (it needs to be learned from krb5-config
binary). This might be a difference.

Is this a known issue? I attach a patch that seems to fix the problem.  I
would be glad if someone here can check the problem and fix the code if it
is not yet already fixed (not synced to github clone).

Thanks,

Vita
-------------- next part --------------
[1119/3103] Compiling libcli/netlogon/netlogon.c
[1120/3103] Compiling libcli/cldap/cldap.c
In file included from ../../lib/addns/dns.h:30,
                 from ../../source4/libcli/resolve/dns_ex.c:42:
../../lib/replace/system/kerberos.h:33:10: fatal error: krb5.h: No such file or 
directory
   33 | #include <krb5.h>
      |          ^~~~~~~~
compilation terminated.

Waf: Leaving directory `/builds/$LOGNAME/samba-nightly.ul/components/samba/build/amd64/bin/default'
Build failed 
 -> task in 'LP_RESOLVE' failed with exit status 1 (run with -v to display more information)


....

[1203/3103] Compiling source3/libsmb/cliconnect.c
[1204/3103] Compiling source3/libsmb/cli_smb2_fnum.c
In file included from ../../source3/libads/kerberos_proto.h:33,
                 from ../../source3/libsmb/namequery.c:33:
../../lib/replace/system/kerberos.h:33:10: fatal error: krb5.h: No such file or directory
   33 | #include <krb5.h>
      |          ^~~~~~~~
compilation terminated.

Waf: Leaving directory `/builds/$LOGNAME/samba-nightly.ul/components/samba/build/amd64/bin/default'
Build failed
 -> task in 'LIBNMB' failed with exit status 1 (run with -v to display more information)

...

[1948/3103] Compiling lib/tdb/tools/tdbtorture.c
[1949/3103] Linking bin/default/lib/talloc/pytalloc.cpython-311.so
In file included from ../../source3/libads/kerberos_proto.h:33,
                 from ../../source3/include/ads.h:79,
                 from ../../source3/utils/net_proto.h:26,
                 from ../../source3/utils/net.h:183,
                 from ../../source3/utils/net_ads_join_dns.c:24:
../../lib/replace/system/kerberos.h:33:10: fatal error: krb5.h: No such file or directory
   33 | #include <krb5.h>
      |          ^~~~~~~~
compilation terminated.

In file included from ../../source3/libads/kerberos_proto.h:33,
                 from ../../source3/include/ads.h:79,
                 from ../../source3/utils/net_proto.h:26,
                 from ../../source3/utils/net.h:183,
                 from ../../source3/utils/net_dns.c:23:
../../lib/replace/system/kerberos.h:33:10: fatal error: krb5.h: No such file or directory
   33 | #include <krb5.h>
      |          ^~~~~~~~
compilation terminated.

Waf: Leaving directory `/builds/$LOGNAME/samba-nightly.ul/components/samba/build/amd64/bin/default'
Build failed
 -> task in 'DNS_UTIL' failed with exit status 1 (run with -v to display more information)
 -> task in 'DNS_UTIL' failed with exit status 1 (run with -v to display more information)

-------------- next part --------------
diff -rup samba-4.19.6-master/source3/utils/wscript_build samba-4.19.6-master.new/source3/utils/wscript_build
--- samba-4.19.6-master/source3/utils/wscript_build	2024-06-03 13:10:11.000000000 +0200
+++ samba-4.19.6-master.new/source3/utils/wscript_build	2024-06-03 19:39:18.683596593 +0200
@@ -9,7 +9,7 @@ bld.SAMBA3_SUBSYSTEM('CONN_TDB',
 
 bld.SAMBA3_SUBSYSTEM('DNS_UTIL',
                      source='net_dns.c net_ads_join_dns.c',
-                     deps='addns')
+                     deps='addns krb5')
 
 bld.SAMBA3_BINARY('profiles',
                  source='profiles.c',
diff -rup samba-4.19.6-master/source3/wscript_build samba-4.19.6-master.new/source3/wscript_build
--- samba-4.19.6-master/source3/wscript_build	2024-06-03 13:10:11.000000000 +0200
+++ samba-4.19.6-master.new/source3/wscript_build	2024-06-03 19:24:17.763401587 +0200
@@ -908,6 +908,7 @@ bld.SAMBA3_SUBSYSTEM('LIBNMB',
                           addns
                           lmhosts
                           resolv
+			  krb5
                           ''')
 
 bld.SAMBA3_SUBSYSTEM('SERVICES',
diff -rup samba-4.19.6-master/source4/libcli/wscript_build samba-4.19.6-master.new/source4/libcli/wscript_build
--- samba-4.19.6-master/source4/libcli/wscript_build	2024-06-03 13:10:11.000000000 +0200
+++ samba-4.19.6-master.new/source4/libcli/wscript_build	2024-06-03 19:22:02.200073053 +0200
@@ -65,7 +65,7 @@ bld.SAMBA_SUBSYSTEM('LIBCLI_RESOLVE',
 bld.SAMBA_SUBSYSTEM('LP_RESOLVE',
 	source='resolve/bcast.c resolve/nbtlist.c resolve/wins.c resolve/dns_ex.c resolve/host.c resolve/lmhosts.c resolve/resolve_lp.c',
 	autoproto='resolve/lp_proto.h',
-	deps='cli-nbt samba-hostconfig netif addns'
+	deps='cli-nbt samba-hostconfig netif addns krb5'
 	)