Problems on OS/2 since 4.20

[Paul Smedley]

Hi All,

As I've posted previously, I'm maintaining a port of Samba for an OS/2 
derivative (ArcaOS) for some years now, predominantly for the client, 
but I'm also trying to get the current server running.

Versions of the server up to 4.19 are working ok, but 4.20+ break during 
protocol negotiation, and I'm struggling to see why.

A pastebin log of a login attempt is at https://pastebin.com/FNxUpuK7

Looking at previous logs (from 4.19) the problem appears to be at line 
3570 where NT_STATUS_INVALID_PARAMETER is reported. However at line 3568 
NT_STATUS_OK is reported. Tracking through the code, I can't see how/why 
the return code changes from NT_STATUS_OK to 
NT_STATUS_INVALID_PARAMETER. Any suggestions?

My source is at https://github.com/psmedley/samba-os2/tree/samba-os2-4.21.x

Cheers,

Paul