Bug in Samba's implementation of FSCTL_QUERY_ALLOCATED_RANGES?

[David Disseldorp]

Hi David,

On Wed, 28 Aug 2024 11:25:40 +0100, David Howells wrote:

> Hi David,
> 
> I tried to apply the patch to the Fedora samba rpm, but I get:
> 
> mold: error: undefined symbol: torture_assert_size_equal
> >>> referenced by <artificial>
> >>>               /tmp/ccVA4FUD.ltrans35.ltrans.o:(test_ioctl_sparse_qar_truncated.lto_priv.0)
> >>> referenced by <artificial>
> >>>               /tmp/ccVA4FUD.ltrans35.ltrans.o:(test_ioctl_sparse_qar_truncated.lto_priv.0)
> >>> referenced by <artificial>
> >>>               /tmp/ccVA4FUD.ltrans35.ltrans.o:(test_ioctl_sparse_qar_truncated.lto_priv.0)  
> collect2: error: ld returned 1 exit status

I've no idea which Samba version Fedora ships.
torture_assert_size_equal() was added to lib/torture/torture.h via
46f0c2696582 (samba >= 4.20.0).

> Do I actually need the torture test patch?

No, not if you can use your xfstests reproducer. The server fix is now
in Samba's master branch as commit 5e278a52646 ("smb2_ioctl: fix
truncated FSCTL_QUERY_ALLOCATED_RANGES responses").