Can we move Samba to C99 and past -Werror=declaration-after-statement ?

Stefan Metzmacher metze at
Fri Nov 10 09:44:23 UTC 2023

Am 09.11.23 um 23:13 schrieb Martin Schwenke via samba-technical:
> On Fri, 10 Nov 2023 10:58:04 +1300, Andrew Bartlett via samba-technical
> <samba-technical at> wrote:
>> Samba chooses to, for it's C style guide, to enforce -
>> Werror=declaration-after-statement
>> I understand that some prefer the style.
>> However C has moved on as a language, and libraries we use (Python 3.12
>> in this case) don't compile with it, and we are having to do quite some
>> contortions in
>> to build on
>> Fedora 39.
>> See also discussion at
>> Can we agree to just remove this requirement?
>> It will allow us to keep variables closer to their use, which is
>> helpful in a lot of ways, particularly in longer functions.
> I think that sounds good.  Yes from me.

I'd like to keep -Werror=declaration-after-statement as long as possible.

Variables appearing in the middle of a function, particularly in longer functions,
are really confusing to me. Thinks like common cleanup via goto would not know of a variable
exists yet...

And every time I saw a patch with the use a declaration in the middle,
I immediately thought this would lead to sloppy coding if we would allow that everywhere.

> Can we also please declare for loop variable in the loop?

These would be very useful and I just checked they also work with /opt/IBM/xlC/16.1.0/bin/xlC on AIX.


More information about the samba-technical mailing list