[PATCH] pidl: actually allow "include" directive usage

Michael Tokarev mjt at tls.msk.ru
Sat Jan 28 21:27:51 UTC 2023

29.01.2023 00:00, Michael Tokarev via samba-technical wrote:
> pidl used to have non-standard helper() and depends()
> attributes. Commit d8ecabe452f36302105c6412ae5ab93cabfe5cf2
> (in Nov 2006) implemented the standard include and import
> directives, but it had a tiny omission: the "include" has
> never been actually pushed to the list to be processed
> later.  This commit adds implementation of type-IMPORT
> typle and type-INCLUDE typle into a few places, and it
> adds type-IMPORT typle to the list to process, but it
> does not add the type-INCLUDE tuple to that list to be
> processed later by the type-INCLUDE implementations.
> This one-line omission lasted for 18+ years together with
> the ton of warnings telling that helpe() is deprecated
> and include should be used instead.
> This tiny fix finally allows to convert helper() to the
> standard include and get rid of this warning finally.

The grammar is bad, and I'm sending this to the list instead
of doing an MR, - because this is an RFC for now.

I can convert all (or most) helper()s into include together
with this change and create an MR with that.

The resulting thing (together with quite some helper()=>include
conversins) builds fine (and without those annoying deprecation

Does it make sense?


More information about the samba-technical mailing list