[SCM] Samba Shared Repository - branch master updated

Martin Schwenke martin at meltin.net
Wed Jan 25 02:15:43 UTC 2023

On Tue, 24 Jan 2023 17:22:30 -0800, Jeremy Allison via samba-technical
<samba-technical at lists.samba.org> wrote:

> On Tue, Jan 24, 2023 at 02:50:37PM +0100, Andreas Schneider via samba-technical wrote:
> >
> >I suggest to use my `git review+` tool :-)
> >
> >https://git.cryptomilk.org/users/asn/dotfiles.git/tree/git/bin/git-review+
> >
> >same for signoff:
> >https://git.cryptomilk.org/users/asn/dotfiles.git/tree/git/bin/git-signoff+  
> Great work Andreas ! Although I personally prefer to use the
> "Reviewed-by: <myself>" tag as a mark I've actually read and
> understood the code I've merged in my tree.
> Whilst I'm reviwing someone's patch I leave off the "Reviewed-by: <myself>" tag
> on patches I don't understand, and only add them once I'm
> good with the code.
> So doing a bulk add of "Reviewed-by: <myself>" actually breaks
> my workflow.
> Does anyone else do this, or am I just strange ? :-).

Strange... but a previous, similar discussion either here or on the
team list suggests that you're not the only one.  :-)

I've been using the Reviewed-by: tag as a rubber stamp since day 1.  I
probably waste time, but if there's something I don't understand I
either remember what it was or I re-review everything.  Then, when I'm
happy, I mechanically appear the rubber stamp to all commits.

peace & happiness,

More information about the samba-technical mailing list