standard samba git commands

Andrew Bartlett abartlet at samba.org
Tue Jan 24 17:52:59 UTC 2023


On Tue, 2023-01-24 at 17:54 +0100, Andreas Schneider via samba-
technical wrote:
> On Tuesday, 24 January 2023 14:50:37 CET Andreas Schneider via samba-technical 
> wrote:
> > > > commit 35a32171b5067d5b80acffc99f8d43cdc7f5f9a7
> > > > Author: Volker Lendecke <vl at samba.org>
> > > > Date:   Wed Jan 11 08:18:35 2023 +0100
> > > > 
> > > >      smbd: Fix a typo
> > > >      
> > > >      Signed-off-by: Volker Lendecke <vl at samba.org>
> > > >      Reviewed-by: Stefan Metzmacher <metze at samba.org>
> > > 
> > > These were all reviewd by me...
> > > 
> > > metze
> > 
> > I suggest to use my `git review+` tool :-)
> > 
> > https://git.cryptomilk.org/users/asn/dotfiles.git/tree/git/bin/git-review+
> > 
> > same for signoff:
> > https://git.cryptomilk.org/users/asn/dotfiles.git/tree/git/bin/git-signoff+
> 
> Oh and I have a review check in for my 'autobuild' command.
> 
> https://git.cryptomilk.org/users/asn/dotfiles.git/tree/git/.gitconfig#n113
> 
> line 113-119
> 
> This will warn you if there are unreviewed patches.
> 

For a long time I've been keen to see us have team-standard tooling in
this area.  It would be great if a ./configure (perhaps only with --
enable-developer) would set up an agreed set of standard git aliases
for the current repo, alongside the pre-commit hook.  This would help
new and old users alike, and allow us to document these things in our
wiki and pass around updated tools consistently. 

Andrew Bartlett

-- 
Andrew Bartlett (he/him) https://samba.org/~abartlet/
Samba Team Member (since 2001) https://samba.org
Samba Developer, Catalyst IT https://catalyst.net.nz/services/samba



More information about the samba-technical mailing list