[PATCH v1 1/1] cifs: Get rid of unneeded conditional in the smb2_get_aead_req()
Steve French
smfrench at gmail.com
Fri Jan 20 19:17:47 UTC 2023
merged into cifs-2.6.git for-next
On Fri, Jan 20, 2023 at 8:22 AM Paulo Alcantara via samba-technical
<samba-technical at lists.samba.org> wrote:
>
> Andy Shevchenko <andriy.shevchenko at linux.intel.com> writes:
>
> > In the smb2_get_aead_req() the skip variable is used only for
> > the very first iteration of the two nested loops, which means
> > it's basically in invariant to those loops. Hence, instead of
> > using conditional on each iteration, unconditionally assing
> > the 'skip' variable before the loops and at the end of the
> > inner loop.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> > ---
> > fs/cifs/smb2ops.c | 14 +++++++++-----
> > 1 file changed, 9 insertions(+), 5 deletions(-)
>
> Reviewed-by: Paulo Alcantara (SUSE) <pc at cjr.nz>
>
--
Thanks,
Steve
More information about the samba-technical
mailing list