IPv6 and commit d882add695bbd5ea03961c08ac2c0380fbf2947b
Jeremy Allison
jra at samba.org
Tue Sep 27 19:23:01 UTC 2022
On Mon, Sep 26, 2022 at 08:53:13PM -0400, Nathaniel W. Turner wrote:
> On Mon, Sep 26, 2022 at 12:48 PM Jeremy Allison <[1]jra at samba.org> wrote:
>
> On Sat, Sep 24, 2022 at 10:17:07PM -0400, Nathaniel W. Turner wrote:
> > On Fri, Sep 23, 2022 at 6:22 PM Jeremy Allison <[1][2]jra at samba.org>
> wrote:
> >
> > This code:
> >
> > * We're only returning up to 2 addresses per
> > * DC name, so just allocate size numdcs x 2.
> > */
> >
> > dclist = talloc_zero_array(mem_ctx,
> > struct ip_service_name,
> > numdcs * 2);
> > if (!dclist) {
> > TALLOC_FREE(dcs);
> >
> > needs an integer wrap tests for numdcs * 2 before
> > passing it to an allocation function. Something
> > like:
> >
> > if (numdcs + numdcs < numdcs) {
> > TALLOC_FREE(dcs);
> > return NT_STATUS_INVALID_PARAMETER;
> > }
> >
> > Oh, good point. Updated.
> > Does the overall approach seem like an OK compromise for now?
> > Changing process_dc_dns() to do parallel pings does seem like a
> natural
> > next step, but is also much larger in scope. I might be able to work
> on
> > that at some point, but my time (and risk tolerance) is pretty
> limited at
> > the moment.
>
> Err. Can you resend the gitlab URLs. I forgot to save them (sorry).
>
> Sure, the proposed change is at
> [3]https://gitlab.com/nathanielwyliet/samba/-/merge_requests/1 and I can
> file a bug and open a real merge request
> at [4]https://gitlab.com/samba-team/samba/-/merge_requests if this seems
> like a reasonable path forward.
This looks a good fix to me. Can you log a bug and create a gliblab
MR for me to review ?
Thanks,
Jeremy.
More information about the samba-technical
mailing list