IPv6 and commit d882add695bbd5ea03961c08ac2c0380fbf2947b

[Nathaniel W. Turner]

On Fri, Sep 16, 2022 at 4:17 PM Nathaniel W. Turner <
nathanielwyliet at gmail.com> wrote:

> Hi folks,
>
> I'm investigating an apparent regression in IPv6 support in the "net"
> command, and I have some questions about commit
> d882add695bbd5ea03961c08ac2c0380fbf2947b.
>
> It looks like it was intended to improve and simplify DNS lookups, but
> unless I'm reading it wrong, it seems to have introduced the assumption
> that if a DC has IPv4 addresses, all clients will too.
>
> If a DC is configured to support both IPv4 and IPv6, and a client in that
> environment is configured IPv6-only (e.g. as part of a transition to
> all-IPv6), it looks like the logic will pick one of the DC's IPv4 addresses
> and ignore it's IPv6 addresses.
>
> Am I missing something?
>

Here's the commit message for context (sorry, meant to include this):

commit d882add695bbd5ea03961c08ac2c0380fbf2947b
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Jul 21 22:09:27 2020 -0700

    s3: libsmb: Make discover_dc_dns() use async DNS.

    Change to call dns_lookup_list_async(). This is
    doing the samba SRV lookup followed by A and AAAA
    record host lookup as resolve_ads() does and so
    benefits from the same changes to make it async.

    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>