vfs_crossrename not working in samba-4.15.*

[Ralph Boehme]

On 10/7/22 16:25, Pavel Filipenský wrote:
> I believe that the bug was introduced in
> 
> 5c18f07 2021-06-16 21:01 -0700 Jeremy Allison     o s3: VFS: 
> crossrename. Use real dirfsp for SMB_VFS_RENAMEAT()
> 
> 
> which removes
> 
> -       if (unlink (dest) && errno != ENOENT) {
> 
> and adss
> 
> 
> +       ret = SMB_VFS_NEXT_UNLINKAT(handle,..
> +       if (ret == -1) {
> 
> =====
> 
> I am trying to fix it in master via reintroducing 'errno != ENOENT' but 
> the fix panics in _share_mode_entry_prepare_lock()
> 
> ...

I guess this is complicated in master due a possible problem/interaction 
with metze's new locking code that was merged a few days ago.

-slow

-- 
Ralph Boehme, Samba Team                 https://samba.org/
SerNet Samba Team Lead      https://sernet.de/en/team-samba

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20221007/b7fcc04e/OpenPGP_signature.sig>