vfs_crossrename not working in samba-4.15.*

[Pavel Filipenský]

I believe that the bug was introduced in

5c18f07 2021-06-16 21:01 -0700 Jeremy Allison     o s3: VFS: 
crossrename. Use real dirfsp for SMB_VFS_RENAMEAT()


which removes

-       if (unlink (dest) && errno != ENOENT) {

and adss


+       ret = SMB_VFS_NEXT_UNLINKAT(handle,..
+       if (ret == -1) {

=====

I am trying to fix it in master via reintroducing 'errno != ENOENT' but 
the fix panics in _share_mode_entry_prepare_lock()

...




On 10/7/22 15:41, Ralph Boehme wrote:
> () is only in master, so how comes you have this in a SBT from 4.15?
>
> -slow