[PATCH][smb3 client] log less confusing message on multichannel mounts to Samba when no interfaces returned

Steve French smfrench at gmail.com
Mon Oct 3 04:38:04 UTC 2022

On Sat, Oct 1, 2022 at 6:22 PM Tom Talpey <tom at talpey.com> wrote:
> On 10/1/2022 12:54 PM, Steve French wrote:
> > Some servers can return an empty network interface list so, unless
> > multichannel is requested, no need to log an error for this, and
> > when multichannel is requested on mount but no interfaces, log
> > something less confusing.  For this case change
> >     parse_server_interfaces: malformed interface info
> > to
> >     empty network interface list returned by server
> Will this spam the log if it happens on every MC refresh (10 mins)?
> It might be helpful to identify the servername, too.

Yes - I just noticed that in this case (multichannel mount to Samba
where no valid interfaces) we log it every ten minutes.
Maybe best way to fix this is to change it to a log once error (with
server name is fine with me) since it is probably legal to return an
empty list (so not serious enough to be worth logging every ten
minutes) and in theory server could fix its interfaces later.

> > Cc: <stable at vger.kernel.org>
> > Signed-off-by: Steve French <stfrench at microsoft.com>
> >
> > See attached patch
> >



More information about the samba-technical mailing list