[SCM] Samba Shared Repository - smbclient rate limit

Jeremy Allison jra at samba.org
Thu Nov 3 16:34:05 UTC 2022


On Thu, Nov 03, 2022 at 08:11:01AM +0100, Andreas Schneider wrote:
>%s\n",
>> @@ -902,6 +968,13 @@ int main(int argc, char **argv)
>>  			.val        = 'f',
>>  			.descrip    = "Use specified rc file"
>>  		},
>> +		{
>> +			.longName   = "limit-rate",
>> +			.argInfo    = POPT_ARG_INT,
>> +			.arg        = &opt.limit_rate,
>> +			.val        = 'l',
>
>This should use an enum OPT_LIMIT_RATE instead of 'l' or it will confilict
>with common options!

Well you did RB+ it already and that code hasn't changed
from the code you reviewed :-). The 'l' here is the value
returned from the poptGetNextOpt(), not a shortName.

If it's incorrect can you send a follow-up MR and I'll
review. Thanks !

Jeremy.



More information about the samba-technical mailing list