samba-tool domain join segfaults (4.16)

Alexander Bokovoy ab at samba.org
Tue May 24 14:52:28 UTC 2022


On ti, 24 touko 2022, Michael Tokarev via samba-technical wrote:
> 24.05.2022 17:28, Alexander Bokovoy wrote:
> ..
> > > But I wonder about in.debug field, - I'm not sure where this
> > > struct is defined..
> > 
> > It is defined in the libnet_join's IDL file: source3/librpc/idl/libnet_join.idl
> > 
> >                  [in] boolean8 debug,
> > 
> > and boolean8 gets translated to uint8_t in the generated C code.
> > 
> > Since Python API really needs 'int' there, we need to use local int
> > variable and copy its value to &r->in.<variable>. I wonder if other
> > places are affected as well.
> 
> Yeah. I already created the MR for this, - using local vars here and in
> another function: https://gitlab.com/samba-team/samba/-/merge_requests/2544

Thanks. It looks good to me, we need to run pipelines, though. I cannot
trigger one for you, for whatever reasons...

-- 
/ Alexander Bokovoy



More information about the samba-technical mailing list