submitting a fix/patch

[Andrew Bartlett]

On Fri, 2022-04-01 at 21:23 +0300, Michael Tokarev via samba-technical
wrote:
> Hi.
> 
> Samba wiki describes how to submit a patch to samba,
> and it shows gitlab way of doing things. Is it the
> only way? I mean, for small things like spelling
> fixes, one-liners, is it really necessary to create
> a gitlab account?
> 
> I created a bug, https://bugzilla.samba.org/show_bug.cgi?id=15039 ,
> with a patch in it, - should I create a gitlab account
> instead and send an MR as outlined in the wiki?
> 
> I really hate creating accounts everywhere just for
> some small things. I already have 3 accounts on
> samba (wiki, bugzilla and mailman), - thought it
> will be enough, - but it was before I read the
> "contributing" page...

I had hoped our Contribute page was clear enough on this point, but I'm
more than happy to expand on it.

The bit you ask about is here, at the bottom:
https://wiki.samba.org/index.php/Contribute#Mailing_patches_to_samba-technical

In short, patches here and in Bugzilla get lost, whereas a number of
developers keep an active watch on outstanding MRs at 
https://gitlab.com/samba-team/samba/-/merge_requests/

I hope this clarifies things,

Andrew Bartlett

-- 
Andrew Bartlett (he/him)       https://samba.org/~abartlet/
Samba Team Member (since 2001) https://samba.org
Samba Team Lead, Catalyst IT   https://catalyst.net.nz/services/samba

Samba Development and Support, Catalyst IT - Expert Open Source
Solutions