[PATCHv2] cifs-utils: work around missing krb5_free_string in Heimdal

atheik atteh.mailbox at gmail.com
Fri Mar 4 22:51:43 UTC 2022

On 3/4/22, Jeremy Allison <jra at samba.org> wrote:
> Does cifs-utils have a libreplace equivalent ?

I have no idea about libreplace but cifs.upcall.c of
cifs-utils already has a lot of these #ifdefs for
compatibility between MIT and Heimdal KRB5.

> Wouldn't it be easier to test for the existence of
> krb5_free_string() and write a libreplace wrapper
> function so krb5_free_string() can be called from
> all code without #ifdefs in the main code ?

This patch adds just another #ifdef to cifs.upcall.c
so that cifs-utils builds against Heimdal again.

I have attached a new patch that doesn't place the
#ifdefs in the function body.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-cifs-utils-work-around-missing-krb5_free_string-in-H.patch
Type: text/x-patch
Size: 1700 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20220305/b177de6a/0001-cifs-utils-work-around-missing-krb5_free_string-in-H.bin>

More information about the samba-technical mailing list