[ANNOUNCE] cifs-utils release 6.12 ready for download

[Amir Goldstein]

On Thu, Dec 31, 2020 at 10:09 PM Pavel Shilovsky via samba-technical
<samba-technical at lists.samba.org> wrote:
>
> New version 6.12 of cifs-utils has been released today.
>
> Highlighted changes:
>
> - get/setcifsacl tools are improved to support changing owner, group and SACLs
> - mount.cifs is enhanced to use SUDO_UID env variable for cruid
> - smbinfo is re-written in Python language
>
> webpage: https://wiki.samba.org/index.php/LinuxCIFS_utils
> tarball: https://download.samba.org/pub/linux-cifs/cifs-utils/
> git: git://git.samba.org/cifs-utils.git
> gitweb: http://git.samba.org/?p=cifs-utils.git;a=summary
>
> Detailed list of changes since 6.11 was released:
>
> 73008e3 cifs-utils: bump version to 6.12
> 16af2c4 smbinfo: fix fsctl-getobjid output
> 85a7865 smbinfo: fix list-snapshots output and installation
> 207f192 cifs.upcall: drop bounding capabilities only if CAP_SETPCAP is given
> 1a15076 mount.cifs: use SUDO_UID env variable for cruid
> 7156c6e mount.cifs: fix max buffer size when parsing snapshot option
> 8f46aaa Add missing position handling to mount parameters
> gid/backup_gid/snapshot
> 4205fdc cifs.upcall: update the cap bounding set only when CAP_SETPCAP is given
> e406fb1 mount.cifs: update the cap bounding set only when CAP_SETPCAP is given
> c3f8e81 Extend cifs acl utilities to handle SACLs
> 6da2dd3 getcifsacl: return error if input path doesn't exist
> 1f37d9c Fix mount error when mount point has an extra trailing slash.
> 1252355 mount.cifs: ignore comment mount option
> ff54e6f setcifsacl: fix quoting of backslash in man page
> c6507ce Separate binary names using comma in mount.cifs.rst
> aeaa786 cifs-utils: fix probabilistic compiling error
> c608a7f cifs-utils: Don't create symlinks for mans if mans are disabled
> a00e843 cifs-utils: Respect DESTDIR when installing smb3 stuff
> b9d94cd mount.cifs.rst: add nolease mount option
> 3d399e4 Add support for setting owner and group in ntsd
> a138fd1 Convert owner and group SID offsets to LE format
> 9bd8c8d smbinfo: remove invalid arguments to ioctl method
> 422f0e9 smbinfo: rewrite in python
>
> Summary:
>
> Alexander Koch (1):
>       cifs.upcall: drop bounding capabilities only if CAP_SETPCAP is given
>
> Aurelien Aptel (1):
>       smbinfo: rewrite in python
>
> Bjoern Jacke (1):
>       setcifsacl: fix quoting of backslash in man page
>
> Boris Protopopov (3):
>       Convert owner and group SID offsets to LE format
>       Add support for setting owner and group in ntsd
>       Extend cifs acl utilities to handle SACLs
>

Guys,

I realize this question is in a year delay, but how is setting group SID
via smb3_ntsd/smb3_ntsd_full expected to work with this kernel code:

                                switch (handler->flags) {
                                case XATTR_CIFS_NTSD_FULL:
                                        aclflags = (CIFS_ACL_OWNER |
                                                    CIFS_ACL_DACL |
                                                    CIFS_ACL_SACL);
                                        break;
                                case XATTR_CIFS_NTSD:
                                        aclflags = (CIFS_ACL_OWNER |
                                                    CIFS_ACL_DACL);
                                        break;

Shouldn't aclflags include CIFS_ACL_GROUP?
BTW, CIFS_ACL_GROUP was not set even before
smb3_ntsd_full patches.

What am I missing?

Thanks,
Amir.