"access based share enum" is broken since 4.16.0

[Andrew Walker]

On Fri, Dec 23, 2022 at 10:34 AM Andreas Schneider <asn at samba.org> wrote:

> On Friday, 23 December 2022 16:20:06 CET Andrew Walker via samba-technical
> wrote:
> > On Fri, Dec 23, 2022 at 10:12 AM Andreas Schneider <asn at samba.org>
> wrote:
> > > On Monday, 19 December 2022 05:38:33 CET Andrew Walker via
> samba-technical
> > >
> > > wrote:
> > > > On Sun, Dec 18, 2022 at 10:40 PM Vyacheslav Karpukhin via
> > >
> > > samba-technical <
> > >
> > > > samba-technical at lists.samba.org> wrote:
> > > > > Hi,
> > > > >
> > > > > It looks like the access-based share listing is broken in the
> recent
> > > > > versions: "smbclient -L" shows no shares if this option is used.
> > >
> > > Bisecting
> > >
> > > > > points at a7c65958a15149918415b7456d6f20ee8c9669d2. I rolled back
> to
> > >
> > > 4.15
> > >
> > > > > for now.
> > > > >
> > > > > Regards,
> > > > > Vyacheslav
> > > >
> > > > FWIW, I have MR with fix here:
> > >
> https://gitlab.com/samba-team/devel/samba/-/commits/anodos325-fix-access-b
> > > as>
> > > > ed-share-enum
> > >
> > > Hi Andrew,
> > >
> > > I'm sorry, but I don't see a MR with this fix. Also we need a bug for
> it
> > > and
> > > backport it to 4.17 and 4.16.
> > >
> > >
> > > Best regards
> > >
> > >         Andreas
> > >
> > > --
> > > Andreas Schneider                      asn at samba.org
> > > Samba Team                             www.samba.org
> > > GPG-ID:     8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D
> >
> > Fix has already been merged:
> > https://bugzilla.samba.org/show_bug.cgi?id=15265
>
> Oh great, thanks for the pointer!
> --
> Andreas Schneider                      asn at samba.org
> Samba Team                             www.samba.org
> GPG-ID:     8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D
>
>
>
There's an additional share enumeration bugfix here:
https://bugzilla.samba.org/show_bug.cgi?id=15266

Basically, registry shares aren't making it into the list. Regression in
4.17.4 IIRC.
I'm running through CI again.