Linux kernel LOCK_MAND deprecation

Christof Schmitt cs at samba.org
Mon Sep 20 23:34:35 UTC 2021


On Mon, Sep 20, 2021 at 11:08:54AM -0700, Jeremy Allison wrote:
> On Mon, Sep 20, 2021 at 10:44:51AM -0700, Christof Schmitt wrote:
> > On Mon, Sep 13, 2021 at 05:46:38PM -0700, Jeremy Allison via samba-technical wrote:
> > > On Mon, Sep 13, 2021 at 05:07:50PM -0700, Christof Schmitt wrote:
> > > >
> > > > https://gitlab.com/samba-team/samba/-/merge_requests/2170
> > > > removes the code and does some minor cleanups in related codepath.
> > > >
> > > > Jeremy, could you take a look? Should we keep the "kernel share modes"
> > > > config option? Or just remove it?
> > > 
> > > I think we need to keep it, as on "normal" VFS backends
> > > we need a way to turn it off. I'll comment more on the MR:
> > > https://gitlab.com/samba-team/samba/-/merge_requests/2170
> > 
> > This has landed now. Would it make sense to rename the VFS flock call to
> > something else like "filesystem_sharemode" or "kernel_sharemode". It has
> > nothing to do with "flock" at this point, so it looks confusing.
> 
> Yep. Now 4.15.0 has shipped it's a good time to make
> ABI VFS breaking changes.

When you have a minute, could you take a look at these patches?
https://gitlab.com/samba-team/samba/-/merge_requests/2181

Christof



More information about the samba-technical mailing list