Fwd: SAMB_INTERNAL DNS forwarding port merge request - my initial samba submission
matt at mattgrant.net.nz
Fri Sep 3 01:46:16 UTC 2021
Could a current maintainer check this over please.
---------- Forwarded message ---------
From: Matt Grant <matt at mattgrant.net.nz>
Date: Fri, 3 Sept 2021 at 13:45
Subject: SAMB_INTERNAL DNS forwarding port merge request - my initial samba
To: Andrew Bartlett <abartlet at samba.org>
Bug number https://bugzilla.samba.org/show_bug.cgi?id=13355, assigned
to Kai Blin, 2 years ago and never closed.
Could you please review my patch. Merge Request:
NOTE: In the dns_forwarder helpers, there is a rather nasty feature in
Python standard library SocketServer code exposed. You have to subclass
UDPServer to get it to do IPv6.... Checked module documentation in Python
3.9, read source code, and this is the only way to fix this ;-(
Also, testparm does not have any parsing support for the smb.conf dns
forwarder entry as it is specified as a cmd_list.... testparm will take
just anything there and accept it. Lots of other places where IP numbers
are given and no sanity checking done either, so chose to leave well alone,
as that looks like the subject of another improvement project.
Please let me know of any improvements, especially working around the above
nasty. Given, its in the Samba test suite, so its probably not too serious.
Thank you so much!
More information about the samba-technical