"make test" of samba master fails in a privileged Linux container

Tue Mar 9 18:14:07 UTC 2021

On Sun, 2021-02-28 at 10:56 PM, Andrew Bartlett via samba-technical wrote:
> Patches to make 'make test' require a TESTS= parameter might be a good idea, to set expectations correctly, users wanting to at least run over the whole testsuite anyway could run with "TESTS=.".

Following the advice I did run "make test TESTS='^samba3.smb2.acls'" and was surprised to see this fail with:

FAILED (20 failures, 0 errors and 0 unexpected successes in 2 testsuites)

A summary with detailed information can be found in:
  ./st/summary
TOP 10 slowest tests
samba3.smb2.acls(ad_dc) -> 8
samba3.smb2.acls(nt4_dc) -> 5
ERROR: test failed with exit code 1
make: *** [Makefile:16: test] Error 1

Was that to be expected or is something wrong with my setup (which was described here in more detail: https://lists.samba.org/archive/samba-technical/2021-February/136345.html ) ?

-----------
Thanks
Thomas

More details on the failed test:

[2(13)/2 at 13s, 1 errors] samba3.smb2.acls(ad_dc)
smbtorture 4.15.0pre1-DEVELOPERBUILD
Using seed 1615311306
TESTING SID_CREATOR_OWNER
get the original sd
set a sec desc allowing no write by CREATOR_OWNER
try open for write
UNEXPECTED(failure): samba3.smb2.acls.CREATOR(ad_dc)
REASON: Exception: Exception: (../../source4/torture/smb2/acls.c:162) Incorrect status NT_STATUS_OK - should be NT_STATUS_ACCESS_DENIED
TESTING FILE GENERIC BITS
get the original sd
Testing generic bits 0x00000000
UNEXPECTED(failure): samba3.smb2.acls.GENERIC(ad_dc)
REASON: Exception: Exception: (../../source4/torture/smb2/acls.c:441) Incorrect access_flags 0x001f01ff - should be 0x00070080
TESTING FILE OWNER BITS
get the original sd
WARNING!: open succeeded with access mask 0x00000001 of expected 0x00000082 - should fail

UNEXPECTED(failure): samba3.smb2.acls.OWNER(ad_dc)
REASON: Exception: Exception: (../../source4/torture/smb2/acls.c:774) Incorrect status NT_STATUS_OK - should be NT_STATUS_ACCESS_DENIED
TESTING ACCESS BASED ENUMERATION
get the original sd
owner_sid is S-1-5-32-544
UNEXPECTED(failure): samba3.smb2.acls.ACCESSBASED(ad_dc)
REASON: Exception: Exception: (../../source4/torture/smb2/acls.c:2342) SD 0x20081 - can see file smb2-testsd
Doing a full scan on DC=ForestDnsZones,DC=addom,DC=samba,DC=example,DC=com and looking for deleted objects
Doing a full scan on DC=DomainDnsZones,DC=addom,DC=samba,DC=example,DC=com and looking for deleted objects
Doing a full scan on CN=Configuration,DC=addom,DC=samba,DC=example,DC=com and looking for deleted objects
Doing a full scan on DC=addom,DC=samba,DC=example,DC=com and looking for deleted objects
TESTING OWNER RIGHTS
get the original sd
UNEXPECTED(failure): samba3.smb2.acls.OWNER-RIGHTS(ad_dc)
REASON: Exception: Exception: ../../source4/torture/smb2/acls.c:2487: cr.out.maximal_access & ~SEC_STD_DELETE was 1966591 (0x1E01FF), expected 1179787 (0x12008B): Wrong maximum access
python3: lpcfg_do_global_parameter: WARNING: The "lanman auth" option is deprecated
python3: lpcfg_do_global_parameter: WARNING: The "lanman auth" option is deprecated
python3: lpcfg_do_global_parameter: WARNING: The "server schannel" option is deprecated
TESTING OWNER RIGHTS DENY
get the original sd
UNEXPECTED(failure): samba3.smb2.acls.OWNER-RIGHTS-DENY(ad_dc)
REASON: Exception: Exception: ../../source4/torture/smb2/acls.c:2622: cr.out.maximal_access & ~SEC_STD_DELETE was 1966591 (0x1E01FF), expected 1179784 (0x120088): Wrong maximum access
/root/dev/samba/bin/smbd: synthetic_pathref: stat [smb2-testsd] failed: No such file or directorysynthetic_pathref: stat [smb2-testsd] failed: No such file or directoryadd_current_ace_to_acl: malformed ACL in file ACL ! Deny entry after Allow entry. Failing to set on file smb2-testsd/owner_right_deny1.txt.
TESTING OWNER RIGHTS DENY1
get the original sd
UNEXPECTED(failure): samba3.smb2.acls.OWNER-RIGHTS-DENY1(ad_dc)
REASON: Exception: Exception: ../../source4/torture/smb2/acls.c:2764: cr.out.maximal_access & ~SEC_STD_DELETE was 1966591 (0x1E01FF), expected 1179787 (0x12008B): Wrong maximum access
/root/dev/samba/bin/smbd: synthetic_pathref: stat [smb2-testsd] failed: No such file or directorysynthetic_pathref: stat [smb2-testsd] failed: No such file or directoryadd_current_ace_to_acl: malformed ACL in file ACL ! Deny entry after Allow entry. Failing to set on file smb2-testsd/test_deny1.txt.
get the original sd
UNEXPECTED(failure): samba3.smb2.acls.DENY1(ad_dc)
REASON: Exception: Exception: ../../source4/torture/smb2/acls.c:2902: cr.out.maximal_access & ~SEC_STD_DELETE was 1966591 (0x1E01FF), expected 1441931 (0x16008B): Wrong maximum access
teardown_env(nt4_dc)
teardown_env(ad_dc)
dns_hub: after poll()
dns_hub[UDP[10.53.57.64]]: before shutdown()
server_stdin_handler: samba: EOF on stdin - PID 10596 terminating
TESTING OWNER RIGHTS DENY
get the original sd
UNEXPECTED(failure): samba3.smb2.acls.MXAC-NOT-GRANTED(ad_dc)
REASON: Exception: Exception: ../../source4/torture/smb2/acls.c:3016: status was NT_STATUS_OK, expected NT_STATUS_ACCESS_DENIED: Wrong smb2_create result
command: /root/dev/samba/bin/smbtorture  $LOADLIST --configfile=$SMB_CONF_PATH --option='fss:sequence timeout=1' --maximum-runtime=$SELFTEST_MAXTIME --basedir=$SELFTEST_TMPDIR --format=subunit --option=torture:progress=no --option=torture:sharedelay=100000 --option=torture:writetimeupdatedelay=500000 --target=samba3 //$SERVER/tmp -U$USERNAME%$PASSWORD smb2.acls 2>&1  | python3 /root/dev/samba/selftest/filter-subunit --fail-on-empty --prefix="samba3.smb2.acls." --suffix="(ad_dc)"
expanded command: /root/dev/samba/bin/smbtorture  $LOADLIST --configfile=/root/dev/samba/st/client/client.conf --option='fss:sequence timeout=1' --maximum-runtime=1200 --basedir=/root/dev/samba/st/tmp --format=subunit --option=torture:progress=no --option=torture:sharedelay=100000 --option=torture:writetimeupdatedelay=500000 --target=samba3 //addc/tmp -UAdministrator%locDCpass1 smb2.acls 2>&1  | python3 /root/dev/samba/selftest/filter-subunit --fail-on-empty --prefix="samba3.smb2.acls." --suffix="(ad_dc)"
ERROR: Testsuite[samba3.smb2.acls(ad_dc)]
REASON: Exit code was 1

dns_hub[UDP[10.53.57.64]]: after serve_forever()dns_hub[UDP[10.53.57.64]]: after shutdown()
dns_hub[UDP[fd00:0000:0000:0000:0000:0000:5357:5f40]]: before shutdown()

dns_hub[UDP[fd00:0000:0000:0000:0000:0000:5357:5f40]]: after serve_forever()dns_hub[UDP[fd00:0000:0000:0000:0000:0000:5357:5f40]]: after shutdown()

dns_hub: before exit()

FAILED (20 failures, 0 errors and 0 unexpected successes in 2 testsuites)

A summary with detailed information can be found in:
  ./st/summary
TOP 10 slowest tests
samba3.smb2.acls(ad_dc) -> 8
samba3.smb2.acls(nt4_dc) -> 5
ERROR: test failed with exit code 1
make: *** [Makefile:16: test] Error 1