Commit 996560191ac6bd603901dcd6c0de5d239e019ef4 causes strange regression

[Andrew Bartlett]

On Mon, 2021-03-08 at 12:39 +1100, Martin Schwenke via samba-technical
wrote:
> I want to flag this regression as soon as possible (before I really
> understand it) because 4.12.12 is due for release on Thursday and
> this
> may be the last 4.12.x release, due to the imminent release of
> 4.14.0.

Thanks for looking at this.  Bother.

Can you see if --as-needed is being detected on your host?  Previously
it was being used only if we were compiling with GCC, now we test, but
it is possible the test is wrong.

In short, can you look into the config.log and such?

Andrew Bartlett

> This is the commit in question:
> 
> commit 996560191ac6bd603901dcd6c0de5d239e019ef4
> Author: Björn Jacke <bj at sernet.de>
> Date:   Tue Mar 2 22:47:35 2021 +0100
> 
>     wscript: use --as-needed only if tested successfully
>     
>     Some OSes like Solaris based OmiOS don't support this.
>     
>     BUG: https://bugzilla.samba.org/show_bug.cgi?id=14288
>     
>     Signed-off-by: Bjoern Jacke <bjacke at samba.org>
>     Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> 
-- 
Andrew Bartlett (he/him)       https://samba.org/~abartlet/
Samba Team Member (since 2001) https://samba.org
Samba Team Lead, Catalyst IT   https://catalyst.net.nz/services/samba

Samba Development and Support, Catalyst IT - Expert Open Source
Solutions