[PATCH] cifs: ignore the noauto option if it is provided

Steve French smfrench at gmail.com
Wed Jan 27 20:06:32 UTC 2021

I didn't see anything logged in dmesg (when I tried it on 5.11-rc today)
indicating it was a problem (it still tried the mount).Maybe it is stripped
out by user space?

In any case can't hurt to to ignore noauto exlpicitly as we do in 5.10 and

On Wed, Jan 27, 2021, 04:57 Aurélien Aptel via samba-technical <
samba-technical at lists.samba.org> wrote:

> Hi Adam,
> Adam Harvey <adam at adamharvey.name> writes:
> > In 24e0a1eff9e2, the noauto option was missed when migrating to the new
> > mount API. As a result, users with noauto in their fstab mount options
> > are now unable to mount cifs filesystems, as they'll receive an "Unknown
> > parameter" error.
> >
> > This restores the old behaviour of ignoring noauto if it's given.
> I was looking at other fs code and it seems no one explicitely parses
> auto/noauto. Any idea why? This looks like it could be handled somewhere
> else.
> Also I would have expected fsparam_flag_no("auto", Opt_ignore) to allow
> for both auto and noauto.
> Cheers,
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
> GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)

More information about the samba-technical mailing list