Initializing case based parameters during share switch in create_conn_struct_tos_cwd()
shilpa.krishnareddy at gmail.com
Mon Jan 18 10:25:15 UTC 2021
Thanks for the patch. I have verified that it fixes the problem.
On Wed, Jan 13, 2021 at 1:18 AM Jeremy Allison <jra at samba.org> wrote:
> On Tue, Jan 12, 2021 at 11:13:28AM -0800, Jeremy Allison via
> samba-technical wrote:
> >>The case_sensitive and short_case_preserve were null because we were not
> >>initializing these values in conn struct to the share configuration that
> >>were switching to. We are using below settings for the share:
> >>case sensitive = no
> >>preserve case = yes
> >>short preserve case = yes
> >>default case = lower
> >>I used the code changes that are in the below patch and now we return the
> >>folder name in the referral as is. Could you please review this patch and
> >>let me know if it is fine?
> >Thanks Shilpa, this does look correct. It sets up the
> >dfs share in the same way as the case options are created
> >in source3/smbd/service.c:make_connection_snum().
> >I think the best fix here would be to factor this code
> >out into a function called by both make_connection_snum()
> >and create_conn_struct_as_root() so we know they are
> >setting things up identically.
> Here's what I ended up with if you want to test.
> Thanks !
More information about the samba-technical