Conflicting public symbols... (Re: [SCM] Samba Shared Repository - branch master updated)

[Stefan Metzmacher]

Am 10.02.21 um 22:58 schrieb Jeremy Allison via samba-technical:
> On Wed, Feb 10, 2021 at 10:36:18PM +0100, Stefan Metzmacher wrote:
>> Hi,
>>
>>> - Log -----------------------------------------------------------------
>>> commit 551532d007970ab11dca71b532754728a6a78496
>>> Author: xzhao9 <i at xuzhao.net>
>>> Date:   Sun Jan 3 13:02:18 2021 -0500
>>>
>>>     s3:registry Renaming get_charset() to smbreg_get_charset()
>>>
>>>     Rename to smbreg_get_charset() function to avoid naming conflict
>>>     with MariaDB.
>>>
>>>     Signed-off-by: xzhao9 <i at xuzhao.net>
>>>     Reviewed-by: Jeremy Allison <jra at samba.org>
>>>     Reviewed-by: David Mulder <dmulder at suse.com>
>>>
>>>     Autobuild-User(master): Jeremy Allison <jra at samba.org>
>>>     Autobuild-Date(master): Wed Feb 10 21:00:28 UTC 2021 on sn-devel-184
>>
>> Do we need a bug report to backport this?
> 
> I'll create one.
> 
>> There's a similar problem reported here:
>> https://www.downtowndougbrown.com/2021/01/tracking-down-a-segfault-that-suddenly-started-happening/
>>
>> Does anyone have time to have a deeper look?
> 
> Looks like "-fvisibility=hidden" is the way
> to go here.

readelf -a bin/shared/private/libsamba-sockets-samba4.so |grep socket_send |grep GLOBAL
   119: 0000000000013386   186 FUNC    GLOBAL DEFAULT   13 socket_sendto@@SAMBA_4.15.0PRE1_DEVELOPERBUILD
   126: 00000000000131f5   401 FUNC    GLOBAL DEFAULT   13 socket_send@@SAMBA_4.15.0PRE1_DEVELOPERBUILD
   257: 00000000000131f5   401 FUNC    GLOBAL DEFAULT   13 socket_send
   258: 0000000000013386   186 FUNC    GLOBAL DEFAULT   13 socket_sendto

I think we need to find a way to drop all unversioned symbols from private libraries (at least the once
we install with 'make install'. So that ld will never pick up symbols from private libraries if applications
link against out public libraries.

Does anyone now how to do that?

metze


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20210210/480317d4/signature.sig>