Samba git and our MR process (was: Re: ctdb/utils/etcd/ctdb_etcd_lock python => python3)

Andrew Bartlett abartlet at
Wed Apr 28 19:22:11 UTC 2021

On Wed, 2021-04-28 at 13:13 +0200, L.P.H. van Belle via samba-technical 
> Hai Martin, 
> > -----Oorspronkelijk bericht-----
> > Van: Martin Schwenke [mailto:martin at] 
> > Verzonden: woensdag 28 april 2021 12:50
> > Aan: L.P.H. van Belle
> > CC: samba-technical at 
> > Onderwerp: Re: ctdb/utils/etcd/ctdb_etcd_lock python => python3
> > 
> > Hi Louis,

> > Let's just make the obvious change that you suggested.   If we only
> > support Python 3 then we can't leave this script at Python 2.  If
> > it
> > breaks then someone can report a bug and hopefully send a patch.
> > 
> > Can you post a git version of the patch with your 
> > Signed-off-by: line or
> > should I do that and just push it with my Reviewed-by:?
> Yes please do, im atm not setup for git and before i push things into
> git
> I need to be better with my git skills, its to easy for me to mess
> things
> up in the samba git.  :-/ 

I want to reassure you that None of us (essentially) ever push directly
to Samba git master, so it is harder to mess up than you might thing.
 Remember, everything goes up as a MR first, see
and in particular

Also, even if you try to push to master, it will be rejected unless you
go via autobuild, so accidents are pretty hard.

Hopefully this helps you gain some of the confidence you need here.

Andrew Bartlett

Andrew Bartlett (he/him)
Samba Team Member (since 2001)
Samba Team Lead, Catalyst IT

Samba Development and Support, Catalyst IT - Expert Open Source

More information about the samba-technical mailing list