ctdb/utils/etcd/ctdb_etcd_lock python => python3

[L.P.H. van Belle]

Hai Surender, 

Thanks for the reply. 

i've checked the Build-Depends that already contains python3 (and some others). 
I now also noticed that my last debian and build worked out. ( just finished 1 min ago )

Architecture: any
Multi-Arch: foreign
Depends: iproute2 [linux-any],
         lsb-base (>= 3.0-6),
         psmisc,
         samba-libs (= ${binary:Version}),
         sudo,
         tdb-tools,
         time,
         ${misc:Depends},
         ${python3:Depends},        << the one i added as last. 
         ${shlibs:Depends}
Recommends: ethtool [linux-any], python3-etcd, ${rados:Recommends}
Suggests: logrotate, lsof

So.. that was a search for me to get all right. 

Thanks for the replies guys. 

Have a great weekend, stay safe but go out, go bird watching something.. ;-) 
fresh air. 

Greetz, 

Louis

Van: Surender Ameelpur [mailto:Surender.Ameelpur at ibm.com] 
Verzonden: vrijdag 23 april 2021 15:57
Aan: L.P.H. van Belle
CC: samba-technical at lists.samba.org
Onderwerp: RE: ctdb/utils/etcd/ctdb_etcd_lock python => python3



Hi,


can you try updating the Build-Depends field with python3-minimal in the debian/control file.


I had come across not exactly the same build error but similar build issue, for SMB 4.14 on Rhel8.3.


Thank you,
Surender. A


-----"samba-technical" <samba-technical-bounces at lists.samba.org> wrote: ----- To: "samba-technical at lists.samba.org" <samba-technical at lists.samba.org>
From: "L.P.H. van Belle via samba-technical" 
Sent by: "samba-technical" 
Date: 04/23/2021 06:03PM
Subject: [EXTERNAL] RE: ctdb/utils/etcd/ctdb_etcd_lock python => python3


Hai Martin, 


> How exactly does the build fail?
Well, i use cowbuild/pbuilder in Debian 10 and in the end lintian checks the packages and errors with.

E: ctdb: python-script-but-no-python-dep usr/lib/x86_64-linux-gnu/ctdb/ctdb_etcd_lock #!python3 
Even after i added in debian/control
${python3:Depends} for CTDB package


> 
> > I dont know if its really needed but all python references are used
> > with /usr/bin/env python3. 
> > 
> > Just to besure im not breaking something in ctdb here. 
> > Can someone confirm this? 
> > 
> > My fix.
> > 
> > --- a/ctdb/utils/etcd/ctdb_etcd_lock
> > +++ b/ctdb/utils/etcd/ctdb_etcd_lock
> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/python
> > +#!/usr/bin/env python3
> 
> I'd like to be able to give a better answer but I'm not entirely sure
> that the script works with python3 without any other changes. 
>  It looks
> like it should but I don't have a trivial way of testing it 
> (or time to setup a test environment).
> 
> Given that /usr/bin/python isn't supported anymore, we might as well
> change it as above see what bug reports get generated.
> 
> If you're keen to improve the script then you could try to clean it up
> and get rid of warnings from pylint and flake8.  getting rid of the
> obvious whitespace issues might make any python3 issues more obvious.
> Perhaps yapf3 would be useful?

I really wished i had these skills todo that, i would then.. 
:-( 

> 
> peace & happiness,
> martin
> 

Thanks for the reply so far. 

Greetz, 

Louis