CI failure on account of C99

Philipp Gesang philipp.gesang at intra2net.com
Tue Apr 13 09:34:43 UTC 2021


Hi,

I’m preparing a patch for submission which seems to be fine CI
wise except for the centos7-samba-o3 target which errors out [0]
with

    ==> /builds/phgsng/samba/samba-o3.stderr <==
    ../../lib/util/tests/time.c: In function ‘test_normalize_timespec’:
    ../../lib/util/tests/time.c:119:2: error: ‘for’ loop initial declarations are only allowed in C99 mode
      for (int i = 0; i < sizeof(data) / sizeof(data[0]); ++i) {
      ^
    ../../lib/util/tests/time.c:119:2: note: use option -std=c99 or -std=gnu99 to compile your code

AFAICS there’s numerous C99 constructs all over the source and
README.Coding explicitly mentions it. Is there a special
precaution that must be taken for this test target to work?

[0] https://gitlab.com/phgsng/samba/-/jobs/1174823996

Best regards,
Philipp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20210413/77a56f4f/signature.sig>


More information about the samba-technical mailing list