PATCH: make disabling of vfs_snapper consistent with our configure/build system
bj at SerNet.DE
Wed Sep 2 09:50:42 UTC 2020
On 2020-09-02 at 11:21 +0200 David Disseldorp sent off:
> > reverting the mentioned patch is the most simple and straight forward solution
> > as the newly introduced option is not required and the generic module
> > activate/deactive mechanism can be used. Any other solution with redundant new
> > options adds more complexity or and possibly conflicts.
> > RB+ from me for the revert of 7ae03a19b3ca895ba5f97a6bd4f9539d8daa6e0a
> I've submitted https://gitlab.com/samba-team/samba/-/merge_requests/1547
> It fixes --with-shared-modules=!vfs_snapper while keeping explicit
> disable / enable (default) behaviour.
the topic of enabled or disabled or auto by default should actually be a split
off discussion, as this discussion cannot be finished before 4.13.
I mentioned before that I object that we introduce more enabled-by-default
options, which need to be explicitly disabled on all other non-Linux platforms.
See by mail from August 12 for more details on this.
More information about the samba-technical