[PATCH] snapper: add configure option to control build (default: auto)
ddiss at samba.org
Tue May 12 13:42:58 UTC 2020
On Mon, 11 May 2020 16:55:48 -0400, Matt Taylor via samba-technical wrote:
> On Sat, May 9, 2020 at 8:07 PM David Disseldorp <ddiss at samba.org> wrote:
> > Hi Matt,
> > There's some white-space damage below the new samba_add_onoff_option
> > line. The empty line between snapper and cephfs should also be removed.
> > Otherwise this looks fine to me:
> > Reviewed-by: David Disseldorp <ddiss at samba.org>
> > I expect the new default dbus dependency will catch a few people, but
> > the clear instructions on how to disable it should help.
> > As with your other patch, please use git format with a commit message
> > and sign off.
> > See https://wiki.samba.org/index.php/Contribute#Mailing_patches_to_samba-technical
> I've removed the extra white space. I think I did this correctly,
> it's my first time using git to try to submit a patch.
> Thank you for reviewing and working with me on this.
I've submitted this (and your other patch) via:
I ended up backing out the vfs_snapper-enabled-by-default behaviour,
as I was a little worried about fallout from automated build scripts.
More information about the samba-technical