[PATCH] snapper: add configure option to control build (default: auto)

David Disseldorp ddiss at samba.org
Sun May 10 00:07:44 UTC 2020

Hi Matt,

On Fri, 8 May 2020 18:25:41 -0400, Matt Taylor via samba-technical wrote:

> As long as the option to disable is there that works for my scenario.
> I figured since it was automatically including snapper if dbus was
> found previously I would keep that automatic behavior.
> Updated patch attached.  Snapper is enabled by default and configure
> will error out if dbus is not found and --disable-snapper was not
> passed.

There's some white-space damage below the new samba_add_onoff_option
line. The empty line between snapper and cephfs should also be removed.

Otherwise this looks fine to me:
Reviewed-by: David Disseldorp <ddiss at samba.org>

I expect the new default dbus dependency will catch a few people, but
the clear instructions on how to disable it should help.

As with your other patch, please use git format with a commit message
and sign off.
See https://wiki.samba.org/index.php/Contribute#Mailing_patches_to_samba-technical

> I'm contributing as an individual with no corporate
> involvement/restrictions, so does that mean no Signed-Off-by tag is
> needed?  I have another trivial spelling patch to send after this.

As Andrew mentioned, the signed-off-by tag is still needed, but
otherwise this should be good to go.

Thanks for your contribution!

Cheers, David

More information about the samba-technical mailing list