[PATCH] snapper: add configure option to control build (default: auto)

David Disseldorp ddiss at samba.org
Fri May 8 20:24:41 UTC 2020

On Fri, 8 May 2020 14:05:16 -0400, Matt Taylor via samba-technical wrote:

> Recently the samba packages on Gentoo Linux had a hard dependency on
> dbus added.  This is because the vfs_snapper module is enabled
> automagically on the existence of dbus headers with no option to
> disable it.  See: https://bugs.gentoo.org/721320 for the Gentoo bug
> where it was suggested this be reported upstream.
> This patch adds a configure option to control the build of snapper
> similar to other vfs modules.
> Signed-off-by: Matt Taylor <liverbugg at rinux.org>

Thanks for the patch Matt!
The change looks reasonable, although I think I'd prefer to see the
default be True, so that existing packagers aren't affected.

Also, if this work is contributed on behalf of your employer, you'll
need to sign the DCO as described at:

Cheers, David

More information about the samba-technical mailing list