[PATCH] Remove 'samba-tool user add'

Karolin Seeger kseeger at samba.org
Tue May 5 09:57:25 UTC 2020

Hi Björn,

Am 30.04.20 um 12:07 schrieb Björn Baumbach via samba-technical:
>>> Andrew Bartlett via samba-technical <samba-technical at lists.samba.org>
>>> wrote:
>>>> Can someone remind me why it was deprecated?
> On 3/29/17 3:04 PM, Volker Lendecke via samba-technical wrote:
>> Also, shouldn't we align this with the group commands? There we have a
>> "samba-tool group add", but no "samba-tool group create".
> Hi!
> I would like to continue this proposal and like to read your ideas to
> resolve this.
> I've recently opened a merge request with a set of patches which rename
> the "samba-tool group add" command to "samba-tool group create" and
> deprecated the add:
> https://gitlab.com/samba-team/samba/-/merge_requests/1304
> I planned to fix all other "add" subcommands, but I've noticed that most
> of the subcommands like computer, contact, ou, ... use "create" already.
> In addition to the "group add" command there are two further "add"s
> left, but they make really sense, in my opinion. It's "spn add" to add a
> SPN to an account (while the command description says "add - *Create* a
> new spn") and "dns add" to add a DNS record.
> I think the "add" command is generally more comfortable and seems to be
> more natural, even for adding new users or groups to the AD.
> It seems that several people wonder why the "user add" command has been
> renamed to "user create". Unfortunately the commit message does not
> provide this information:
> commit b26a4f6232219746fd8ed1b107476f3c23c6908e
> Author: Theresa Halloran <thallora at linux.vnet.ibm.com>
> Date:   Sun Oct 23 15:23:28 2011 -0700
>     s4: samba-tool subcommand rename - change samba-tool user add to
> samba-tool user create
>     Signed-off-by: Theresa Halloran <thallora at linux.vnet.ibm.com>
>     Signed-off-by: Jelmer Vernooij <jelmer at samba.org>
> What do you think about:
> 1.) Just replace the "group add" with "group create" (and keep "dns add"
>     and "spn add"), like in my merge request.
> 2.) Have both, "add" and "create", for all subcommands.
> 3.) Roll-back: Remove the "user add" deprecation warning, add the "add"
>     command to all other categories and deprecate all "create" commands.
> Please let me know :-)

first of all, thanks for taking care! :-)

I would prefer "2" to make sure that the user interface does not change
(existing scripts...).


Karolin Seeger			https://samba.org/~kseeger/
Release Manager Samba Team	https://samba.org
Team Lead Samba SerNet		https://sernet.de

More information about the samba-technical mailing list