bug 9612 fix

[Andrew Bartlett]

G'Day Sergey,

Recently another user asked about our smart card login feature, it
would be awesome if you could do as Douglas requests so we can progress
this.

Did you ever submit this upstream?  If so, can you point me to the pull
request so I can look into it?

Thanks!

Andrew Bartlett

On Fri, 2019-06-28 at 09:57 +1200, Douglas Bagnall via samba-technical
wrote:
> Hi Sergey,
> 
> On 27/06/19 11:03 PM, Сергей Корчак via samba-technical wrote:
> > Hello!
> > My name Sergey Korchak, and i work in AstraLinux company. see
> > http://astralinux.ru
> > 
> > I have fixed bug 9612
> > https://bugzilla.samba.org/show_bug.cgi?id=9612
> > 
> > According to GNU GPL we wish to publish our patch.
> 
> Thanks for your work on Samba!
> 
> There are a few more steps to get through, not all of which will be
> easy for this patch, for unfortunate non-technical reasons.
> 
> Firstly, and this is the tricky one, as mentioned in
> https://bugzilla.samba.org/show_bug.cgi?id=9612#c5, our Heimdal is
> horribly entangled with upstream Heimdal, so we really want to get
> patches via upstream.
> 
> Secondly, I anticipate there might be stylistic issues with the patch,
> though it isn't for me to say, since we're delegating review to
> upstream Heimdal. Nevertheless, I wouldn't recommend doing this:
> 
> > +// Begin of AstraLinux patch by Sergey Korchak
> > +// End of AstraLinux patch by Sergey Korchak
> 
> People will use `git blame` to find that out when they need to.
> 
> Thirdly, if you are wanting to contribute to Samba directly, could you
> please send in a Developer's Certificate of Origin as described at
> https://www.samba.org/samba/devel/copyright-policy.html.
> 
> Thanks
> 
> Douglas
> 
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba