Merge Request Template for Gitlab
asn at samba.org
Wed Jun 10 05:23:23 UTC 2020
On Tuesday, 9 June 2020 20:35:01 CEST Andrew Bartlett wrote:
> Thanks for suggesting this. I've made that change so others can give
> feedback based on how this works in the real world.
> The only change I've made is to reference README.Coding not
> > * [ ] Code modified for feature
> I'm not sure exactly what you mean by this checkbox.
Maybe name it: Preparation for a feature
There will be follow up merge requests ...
> > * [ ] Test suite updated with functionality tests
> > * [ ] Test suite updated with negative tests
> > * [ ] Documentation updated
> > * [ ] CI timeout is 3h or higher (see Settings/CICD/General
> > pipelines/
> > Timeout)
> This is not needed for the shared development repo, but saying so in a
> succinct way will be a challenge.
> Some wording pointing at the Contributing page on the wiki might be a
> good idea also.
We could make it a link to the contribution page where it is described in
> > ## Reviewer's checklist:
> > * [ ] Any issues marked for closing are addressed
> > * [ ] There is a test suite reasonably covering new functionality
> > or
> > modifications
> > * [ ] Function naming, parameters, return values, types, etc., are
> > consistent
> > and according to `CONTRIBUTION.md`
> > * [ ] This feature/change has adequate documentation added
> > * [ ] No obvious mistakes in the code
> > ====== /template ======
> > Settings -> General -> Merge Requests -> Default description template
> > for
> > merge requests
> Finally, we should just be aware that this feature is not in GitLab CE,
> so we would loose it (just as we would loose the Approve button) if we
> moved off gitlab.com.
> (That said, it is entirely possible GitLab will open source it if we
> ask, so we should do that)
The templates for Issues go into the git repo via .gitlab/issue_templates
iirc. They would just need to add support for merge requests too. Doesn't seem
to be a too big deal.
> Thank you *so* much for proposing this.
> Everyone else:
> Please have a go with the templates over the next few days and help us
> get one that helps us all!
Sugestions are very welcome. I can then use the improvements for libssh too
Andreas Schneider asn at samba.org
Samba Team www.samba.org
More information about the samba-technical