git signoff+ and review+

Andrew Bartlett abartlet at
Fri Jun 5 09:15:22 UTC 2020

On Fri, 2020-06-05 at 09:56 +0200, Andreas Schneider wrote:
> On Friday, 5 June 2020 02:06:56 CEST Andrew Bartlett wrote:
> > G'Day Andreas,
> Hi Andrew,
> > I wondered if we could have an agreed set of aliases included in
> > Samba?
> You cannot include those in the Samba repository. Those are all
> individual. 
> All you can do, is provide a script which could set them up running
> 'git 
> config'.

Do you mean we can't do it technically, or we shouldn't do it because
we are all individual developers with our own way of doing things?

We already do that for the post-commit hooks automatically, so why not
do it for some common git aliases?

I know strong individuality is a strength of the Samba community - and
I wouldn't dare drag a developer away from the editor - but I would
argue that we could also gain by having some common tools for working
with gitlab and reviews for example.

It means we can then document them in our wiki for example, and know
everyone, even new developers, are running the same commands in the
same way.

Andrew Bartlett

Andrew Bartlett             
Authentication Developer, Samba Team
Samba Developer, Catalyst IT 

More information about the samba-technical mailing list