git signoff+ and review+

[Andrew Bartlett]

G'Day Andreas,

I wondered if we could have an agreed set of aliases included in Samba?

I know that would be some duplication, but I see a big advantage in
taking advantage of the per-repo git aliases[1] to ensure everyone
working on Samba has common tools.

That would in turn mean that we can document our processes on the wiki
using the same tools we use, rather than the current 'do what I say,
not what I do' or more charitably 'these are the documented steps, but
Samba wizards do $THIS day-to-day'. 

Things like review and sign-off scripts, Douglas's 'git mr-branch' and
even the 'git autobuild' hook (with the review check) should be set up
standard, just as we set up the commit check for whitespace (which has
done so much for ending whitespace wars!). 

We would need to choose the command names well - they need to make
sense for newbies as well as experienced developers, but this could
make it a little easier for the next new developer. 

Do you think we could collaborate on this?

Thanks,

Andrew Bartlett

[1] http://alblue.bandlem.com/2011/04/git-tip-of-week-aliases.html


On Wed, 2020-06-03 at 16:35 +0200, Andreas Schneider via samba-
technical wrote:
> I've pushed some improvements to the tools ...
> 
> 
> 
> On Tuesday, 24 March 2020 11:00:11 CEST Andreas Schneider via samba-
> technical 
> wrote:
> > Hello,
> > 
> > as a daily task I have to sign commits and also add my review tag
> > after
> > inspection.
> > 
> > As git-filter-branch has been deprecated and the replacement is
> > git-filter-
> > repo [1], I've written some really nice python tools to make my
> > life easier.
> > 
> > In a git repository I and do:
> > 
> > git signoff+            # Add my signoff to commits I authored.
> > git signoff+ --by metze # Sign commits authored by metze,
> >                         # because he forgot :-)
> > git review+             # Add my RB tag to commits I'm not the
> >                         # author of or which has my sign tag
> > git review+ --by metze  # Add review by metze
> > 
> > 
> > metze is a shortcut, the name you specify is actually a file name
> > placed in
> > 
> > ~/.review
> > 
> > so metze is actually the file ~/.review/metze and the content is
> > his name
> > and mail address.
> > 
> > You can find 'git signoff+' at [2] and 'git review+' at [2]. Just
> > put them
> > in
> > 
> > ~/bin/
> > 
> > and git will find them.
> > 
> > 
> > I hope they will be useful to others.
> > 
> > 
> > 
> > 	Andreas
> > 
> > 
> > [1] https://github.com/newren/git-filter-repo/
> > [2]
> > 
https://git.cryptomilk.org/users/asn/dotfiles.git/tree/git/bin/git-signoff+
> > [3]
> > 
https://git.cryptomilk.org/users/asn/dotfiles.git/tree/git/bin/git-review+
> 
> 
-- 
Andrew Bartlett                       https://samba.org/~abartlet/
Authentication Developer, Samba Team  https://samba.org
Samba Developer, Catalyst IT          
https://catalyst.net.nz/services/samba