Problematic port field in struct ip_service in Samba.
jra at samba.org
Fri Jul 17 22:05:00 UTC 2020
On Fri, Jul 17, 2020 at 07:58:38AM +0200, Andreas Schneider wrote:
> On Friday, 17 July 2020 00:26:00 CEST Jeremy Allison via samba-team wrote:
> > Hi Team & all interested parties,
> Hi Jeremy,
> > Eventually I'd like to replace all
> > uses of struct ip_service -> struct sockaddr_storage,
> > but that's a bigger cleanup for another
> > day.. :-).
> we actually should replace this with `struct samba_sockaddr`
> to avoid strict aliasing issues!
> See lib/util/util_net.h for `struct samba_sockaddr`
> I've just recently had to fix a crash on arm in nss_wrapper which was caused
> by not following strict aliasing rules:
Good point. But I'll move to struct sockaddr_storage first
- I already have that working with my test async DNS
as that's what most of the calling code expects.
We can then move to struct samba_sockaddr in stages after.
Don't want to boil the ocean today, just heat up some
small pots and pans full :-).
More information about the samba-technical